Fix declared references support for local and improve reference retur…#40
Merged
Fix declared references support for local and improve reference retur…#40
Conversation
…n values This commit improves support for declared references (feature 'declared_refs') in t/op/decl-refs.t, fixing 40+ test failures. Changes in OperatorParser.java: - Added declared_refs feature checking and experimental warning to parseLocal() - Implemented support for local \$x, local(\$x), and local\\($x) syntax - Added handling for declared references inside parentheses for local Changes in EmitVariable.java: - Fixed my \$x to properly return a reference to the declared variable - Added support for my \\\$x (reference to a declared reference) - Changed declared reference emission to call createReference() in non-void context Test Results: - Before: 144 tests passing - After: 148 tests passing (4 failures remain due to unrelated issues) - Fixed all 36 local-related declared reference tests (109-144) - Fixed declared reference return values (test 145) Remaining issues (not addressed in this commit): - Package vs lexical variable lookup (\$::a resolving incorrectly) - List context return values for declared references - Reference to list of declared references
fglock
added a commit
that referenced
this pull request
Apr 26, 2026
… exit When a global @array or %hash is localized via `local @x`/`local %x`, GlobalRuntimeArray/GlobalRuntimeHash swap the global slot with a fresh empty container. If the local container is then blessed during the scope (e.g. `bless \@x, 'Class'`), at scope exit the local container is discarded silently — DESTROY never fires. This is what postfixderef.t #40 "no stooges outlast their scope" exercises via `local @curly; bless \'curly'->@*, 'coulda';` (symref deref). Fix: in GlobalRuntimeArray.dynamicRestoreState and GlobalRuntimeHash .dynamicRestoreState, before swapping the original container back, check if the displaced (local) container is blessed and DESTROY hasn't already fired. If so, mark refCount = MIN_VALUE and call DestroyDispatch .callDestroy(localContainer). The destroyFired guard prevents double-fire when an inner `my $obj = bless \@x, ...` already cascaded DESTROY first. Also propagate the same logic to RuntimeArray/RuntimeHash dynamicRestoreState for the in-place save/restore path used by lexical aliases / DynamicVariableManager. Test: perl5_t/t/op/postfixderef.t #40 now passes (previously failing). Verified gates: - make: BUILD SUCCESSFUL, all unit tests PASS - DBIC: 313/314 (1 flake, t/cdbi/68-inflate_has_a.t passes standalone) - Moo: 71/71 PASS - Template::Toolkit: 106/106 PASS - op/local.t: identical baseline (no regression) Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
fglock
added a commit
that referenced
this pull request
Apr 26, 2026
… exit When a global @array or %hash is localized via `local @x`/`local %x`, GlobalRuntimeArray/GlobalRuntimeHash swap the global slot with a fresh empty container. If the local container is then blessed during the scope (e.g. `bless \@x, 'Class'`), at scope exit the local container is discarded silently — DESTROY never fires. This is what postfixderef.t #40 "no stooges outlast their scope" exercises via `local @curly; bless \'curly'->@*, 'coulda';` (symref deref). Fix: in GlobalRuntimeArray.dynamicRestoreState and GlobalRuntimeHash .dynamicRestoreState, before swapping the original container back, check if the displaced (local) container is blessed and DESTROY hasn't already fired. If so, mark refCount = MIN_VALUE and call DestroyDispatch .callDestroy(localContainer). The destroyFired guard prevents double-fire when an inner `my $obj = bless \@x, ...` already cascaded DESTROY first. Also propagate the same logic to RuntimeArray/RuntimeHash dynamicRestoreState for the in-place save/restore path used by lexical aliases / DynamicVariableManager. Test: perl5_t/t/op/postfixderef.t #40 now passes (previously failing). Verified gates: - make: BUILD SUCCESSFUL, all unit tests PASS - DBIC: 313/314 (1 flake, t/cdbi/68-inflate_has_a.t passes standalone) - Moo: 71/71 PASS - Template::Toolkit: 106/106 PASS - op/local.t: identical baseline (no regression) Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…n values
This commit improves support for declared references (feature 'declared_refs') in t/op/decl-refs.t, fixing 40+ test failures.
Changes in OperatorParser.java:
Changes in EmitVariable.java:
Test Results:
Remaining issues (not addressed in this commit):